Nan threshold for conservative regridding (continuation of #39)

xarray-contrib / xarray-regrid

Regridding utility for xarray

https://xarray-regrid.readthedocs.org/

Apache License 2.0

72 stars 7 forks source link

Nan threshold for conservative regridding (continuation of #39) #41

Closed BSchilperoort closed 2 months ago

BSchilperoort commented 2 months ago

Continuation of #39

Corrected the typing of the modified routines
Added a demo notebook (based on the example from #39)
Added @slevang to contributors

BSchilperoort commented 2 months ago

@slevang I tidied up some things and added additional documentation to your PR. Could you have a (quick) look at this? If not just let me know and I merge it as-is

slevang commented 2 months ago

Thanks, and good timing! I finally have some free time this week and was planning to finish this up.

I did want to revisit the way I implemented the NaN thresholding across dimensions following this comment, and maybe try being more explicit by having the user pass a mask.

BSchilperoort commented 2 months ago

Thanks, and good timing! I finally have some free time this week and was planning to finish this up.

I did want to revisit the way I implemented the NaN thresholding across dimensions following this comment, and maybe try being more explicit by having the user pass a mask.

Great! Maybe it's better to merge this PR first, so you can work in a clean branch. That would be easier to review.

I did move those comments to https://github.com/EXCITED-CO2/xarray-regrid/issues/42 already