xarray-contrib / xarray-schema

Schema validation for Xarray objects
https://xarray-schema.readthedocs.io/en/latest/index.html
MIT License
39 stars 8 forks source link

Chunks #2

Closed orianac closed 2 years ago

orianac commented 2 years ago

Three changes:

codecov-commenter commented 2 years ago

Codecov Report

Merging #2 (d4eb889) into main (0a60625) will increase coverage by 0.86%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   87.17%   88.04%   +0.86%     
==========================================
  Files           2        2              
  Lines          78       92      +14     
==========================================
+ Hits           68       81      +13     
- Misses         10       11       +1     
Impacted Files Coverage Δ
xarray_schema/core.py 87.50% <95.23%> (+1.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a60625...d4eb889. Read the comment docs.

orianac commented 2 years ago

@jhamman Take a look- added logic to cover chunks being True, False or a dict, and added a few more tests to cover some corner cases.

jhamman commented 2 years ago

Thanks @orianac. I'm going to merge now!