Fix saving output variables with dtype=object

xarray-contrib / xarray-simlab

Xarray extension and framework for computer model simulations

http://xarray-simlab.readthedocs.io

BSD 3-Clause "New" or "Revised" License

73 stars 9 forks source link

Fix saving output variables with dtype=object #145

Closed bgailleton closed 4 years ago

bgailleton commented 4 years ago

…able dtype is object or np.object. It works at runtime and the variable is successfully saved in the Dataset, but it fails at sabing to file Closes #144

[x] Closes #144
[x] Tests added
[x] Passes black . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

benbovy commented 4 years ago

LGTM, I pushed some commits to update an existing test for this.

Thanks again @bgailleton!