search

xarray-contrib / xarray-simlab

Xarray extension and framework for computer model simulations
http://xarray-simlab.readthedocs.io
BSD 3-Clause "New" or "Revised" License
73 stars 9 forks source link

Output variables attribute of input dataset accidentally removed #55

Closed benbovy closed 5 years ago

benbovy commented 5 years ago

This prevents just reusing the input dataset as a base setup for other simulations.

The origin of this issue is that xarray.Dataset.update() doesn't make a copy of the attrs dictionary. See:

https://github.com/benbovy/xarray-simlab/blob/23567e09a0b5b868de8ed3e5319e76d816a5dfc3/xsimlab/drivers.py#L236

benbovy commented 5 years ago

Fixed in #54 and #56.