From my understanding, foreign variables always belong to xsimlab variables. Therefore, we technically could use attr.fields_dict() instead. What do you think, @benbovy ?
My first inclination was, to iterate over variables_dict(other_process_cls).items() but luckily, the construct makes it accessibly as is 👍
There's already a test included in test_variable.py. Should we update this one to account for these changes or is it better to test at another place (e.g. as part of autodoc)?
PR#88 was closed and the code has been changed in order to work independently from the autodoc-feature (PR#67).
black . && flake8
whats-new.rst
for all changesI use
variables_dict()
fromutils.py
. Since attrs is already imported invariables.py
, the following line would return the same result:From my understanding, foreign variables always belong to xsimlab variables. Therefore, we technically could use
attr.fields_dict()
instead. What do you think, @benbovy ? My first inclination was, to iterate overvariables_dict(other_process_cls).items()
but luckily, the construct makes it accessibly as is 👍There's already a test included in
test_variable.py
. Should we update this one to account for these changes or is it better to test at another place (e.g. as part of autodoc)?