Bump GitHub Actions - Githubissues

xarray-contrib / xarray-tutorial

Xarray Tutorials

https://tutorial.xarray.dev/

Apache License 2.0

166 stars 106 forks source link

Bump GitHub Actions #260

Closed scottyhq closed 2 weeks ago

scottyhq commented 1 month ago

Address #259

scottyhq commented 2 weeks ago

I think I've finally cracked the previews by separating "build" and "deploy" into separate workflows. Deploy uses workflow_run: , which is similar to pull_request_target in that it runs on the main branch such that forks can't modify it.

Made a small pull request to the surge-preview action to make this work https://github.com/afc163/surge-preview/issues/297#event-13236626009

Tested here https://github.com/relativeorbit/sarbook/pull/7

scottyhq commented 2 weeks ago

Going to go ahead and merge, can always revert or disable the preview workflow in the future

github-actions[bot] commented 2 weeks ago

😭 Deploy PR Preview cf65eabd90a2417bc6cd354e3badf4620a007681 failed. Build logs

_{🤖 By surge-preview}