search

xarray-contrib / xarray-tutorial

Xarray Tutorials
https://tutorial.xarray.dev/
Apache License 2.0
166 stars 106 forks source link

improving the advanced indexing notebooks #264

Closed negin513 closed 1 week ago

negin513 commented 1 month ago

This PR should address issue #206 .

I created and added a schematic image to explain different indexing types. I also added more examples to the notebook for more clarify.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

negin513 commented 1 month ago

I am not sure why the preview of notebook is failing. There is a duplicate label warning : 

 WARNING: duplicate label: indexing-1; other instance in /home/runner/work/xarray-tutorial/xarray-tutorial/fundamentals/02.1_indexing_Basic.ipynb

But I don't see any similar titles. Coud this be related to myst_parser issue?

Nevermind this was caused by duplicated exercise names.

dcherian commented 1 month ago

👏🏾 :clap: i love this image!

we should get it in the main docs too.

github-actions[bot] commented 2 weeks ago

:recycle: PR Preview 383eeae6263bf4db3ee4db17e4657231ba42fd12 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

scottyhq commented 2 weeks ago

@negin513 just a heads up - I added a couple commits to sync with the latest environment and enable the website preview link, so you can see your changes here https://xarray-contrib-xarray-tutorial-preview-pr-264.surge.sh/intermediate/indexing/advanced-indexing.html

negin513 commented 1 week ago

@dcherian and @JessicaS11 Thanks so much for your review and feedback provided. I have addressed all the comments and implemented your suggestions. Can you please take a look at this and let me know if this looks good for merging?

Thanks! Negin

dcherian commented 1 week ago

I think meshgrid is an alternative to ix_. I won't have time to review but thanks Negin!

negin513 commented 1 week ago

Thanks @scottyhq , @dcherian , and @JessicaS11 for great comments. I have added the following:

  1. Added a dropdown note box about how to achieve numpy orthogonal indexing.
  2. added %config InlineBackend.figure_format='retina' for rendering