search

xarray-contrib / xarray_leaflet

An xarray extension for tiled map plotting.
https://xarray-leaflet.readthedocs.io
MIT License
157 stars 21 forks source link

Tile URL management #45

Open davidbrochart opened 2 years ago

davidbrochart commented 2 years ago

With #44 the base URL is now automatically retrieved from JupyterLab, so in order to handle any other platform a function returning the base URL must be passed in get_base_url. Closing #42, #40, #39, #37.

Xabitsuki commented 2 years ago

Could you please elaborate on how does this applies to the jupyter notebook use-case ? I just ran the introduction notebook with a freshly created environment as you specidified in #39 and still have no data on the map. Many thanks in advance.

davidbrochart commented 2 years ago

I advise not using the Classic Notebook, which is deprecated in favor of JupyterLab or RetroLab. If you want to use the Classic Notebook, you need to pass a get_base_url argument like this:

def get_base_url(url):
    return "http://localhost:8888"

l = da.leaflet.plot(m, get_base_url=get_base_url)
Xabitsuki commented 2 years ago

Thanks for the hack, it works ! I do not even understand how since my notebook is running on http://localhost:8892/ and not on 8888. Regarding the use of Classic Notebook or Lab there are still features that are present on one platform and missing on the other, e.g. "highlight selected word" that is still not implemented on Lab but present in Classic Notebooks see this issue. I guess there are other examples if considering all jupyter nbextensions. Notebooks are still popular.

Anyway, thanks again for the hack and if you need, I would be happy to contribute to implement it.

davidbrochart commented 2 years ago

I do not even understand how since my notebook is running on http://localhost:8892/ and not on 8888

Yes, this is strange :eyes:

Regarding the use of Classic Notebook or Lab there are still features that are present on one platform and missing on the other

That's true, but nobody is working on the Classic Notebook so it will die eventually.

Anyway, thanks again for the hack and if you need, I would be happy to contribute to implement it.

Implement what?

Xabitsuki commented 2 years ago

Indeed you are right, forget what I said about implementing this hack I will just move on to Lab and wait for the features to come. Merci pour vos réponses et bonne soirée.