xarray-contrib / xarray_leaflet

An xarray extension for tiled map plotting.
https://xarray-leaflet.readthedocs.io
MIT License
163 stars 21 forks source link

Add vector rendering #69

Closed davidbrochart closed 2 years ago

davidbrochart commented 2 years ago

This PR adds support for GeoDataFrame rendering.

https://user-images.githubusercontent.com/4711805/182647979-6b24d0b0-8584-48fd-9e31-b837214a4460.mp4

Closes #22.

davidbrochart commented 2 years ago

The vector data-flow (where the data source is a GeoDataFrame) has diverged quite a bit from the raster data-flow (where the data source is a DataArray). But I think it's possible to reconcile, because an internal DataArray is built in the vector data-flow. We could just treat it as a source for a raster data-flow, and benefit from it. For this, I think that the raster data-flow should adopt the same strategy of having an intermediate DataArray where chunks are aligned with tiles (for a given zoom level), and that is already re-projected.

jfoster17 commented 2 years ago

I'm happy to report that this change fixed things in Safari!

I'm not entirely sure about the change to make the layers not disappear while computing. On the one hand, it retains some information while we wait, so that's good. But displaying a blank layer helps the user to recognize that the system is doing something -- if you're not watching the swirling "in-progress" badge. I think a new user might think that nothing changes on zoom and be confused by that.

davidbrochart commented 2 years ago

Happy to hear that it now works in Safari! About not removing the layer while it's computing, it's actually what Safari didn't like. The thing is that when e.g. we zoom in, Leaflet immediately makes requests to get the new tiles. In parallel, the kernel gets notified that the zoom has changed, and if it decides to remove the layer, Leaflet has to cancel the requests, which apparently Safari doesn't like (it probably actually doesn't cancel them, and instead waits for them to time out, before making new requests). I actually like that the previous tiles are zoomed in while it's computing, and it's also the Leaflet behavior (you can see that if the server is slow to respond). If we want to make it clearer that the system is doing something, we could make the spinner fit the whole map. What do you think?

benbovy commented 2 years ago

That's great @davidbrochart!

The vector data-flow (where the data source is a GeoDataFrame) has diverged quite a bit from the raster data-flow (where the data source is a DataArray). But I think it's possible to reconcile, because an internal DataArray is built in the vector data-flow.

I think that eventually it would be great to also support vector data sources directly as Xarray objects (e.g., static spatial features with multi-dimensional attribute data, or even dynamic spatial features like polygons with vertices evolving over time).

The fact that pygeos (and shapely 2.0) support vectorized operations (numpy ufuncs) and that soon Xarray will fully support custom indexes make it possible (i.e., indexed coordinates with geometry objects as array items). dask-geopandas and dask support in Xarray might also make things easier.

It would be nice to also have some convenient methods (public API) for conversion between GeoDataFrame and DataArray / Dataset objects.

davidbrochart commented 2 years ago

I think that eventually it would be great to also support vector data sources directly as Xarray objects

I didn't know that, for me xarray was all about gridded data. That opens up new possibilities indeed!

It would be nice to also have some convenient methods (public API) for conversion between GeoDataFrame and DataArray / Dataset objects.

In this PR xarray-leaflet uses geocube internally, which does just that. But if it's all integrated in xarray, even better.

Do you know when all of that will land in xarray?

benbovy commented 2 years ago

Hmm I think that's out of scope for having such methods implemented in Xarray itself, but it may probably fit nicely in an Xarray "geo" extension like Geocube.

davidbrochart commented 2 years ago

Closing in favor of #75.