search

xarray-contrib / xeofs

Comprehensive EOF analysis in Python with xarray: A versatile, multidimensional, and scalable tool for advanced climate data analysis
https://xeofs.readthedocs.io/
MIT License
98 stars 18 forks source link

fix: incorrect explained variance in CCA #147

Closed nicrie closed 7 months ago

nicrie commented 7 months ago

Previously, the explained (co)variance in PCA-CCA was computed with respect to the pre-processed PCA views. Fixed by using the actual (non-PCA) data (see #146)

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@4cf84cf). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ======================================= Coverage ? 94.40% ======================================= Files ? 73 Lines ? 6150 Branches ? 0 ======================================= Hits ? 5806 Misses ? 344 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.