Update setup configuration, CI, etc.

xarray-contrib / xoak

xarray extension that provides tree-based indexes used for selecting irregular, n-dimensional data.

https://xoak.readthedocs.io

MIT License

57 stars 4 forks source link

Update setup configuration, CI, etc. #22

Closed benbovy closed 3 years ago

benbovy commented 3 years ago

Move back from poetry to a bare setup.py (easier to handle with conda)
Use setuptools_scm for versioning
Configure pre-commit (I've recently started using it in other projects and I'm quite happy with it -- no more "fix black" like commits)
Update github actions (lint + test)

benbovy commented 3 years ago

@willirath thanks for activating codecov for the org. I think it will be clearer to have one extra check for coverage instead of triggering test failures. If you can activate builds for pull-requests on readthedocs (in advanced settings), that would be great too!

Let me know if you have any objection regarding the choices made here (e.g., max line length, string delimiters, etc.). Otherwise, I'm going to merge this soon and move on with adding more index wrappers (scipy, pys2index, etc.).

willirath commented 3 years ago

@benbovy What’s your user on readthedocs? I’d like to also add you as maintainer there.

willirath commented 3 years ago

building PRs was already enabled.

benbovy commented 3 years ago

@benbovy What’s your user on readthedocs? I’d like to also add you as maintainer there.

girpas-ulg (the name is because I created it some years ago at my previous work, but I'm the only user).

willirath commented 3 years ago

Added you on rtd.

willirath commented 3 years ago

Let me know if you have any objection regarding the choices made here (e.g., max line length, string delimiters, etc.). Otherwise, I'm going to merge this soon and move on with adding more index wrappers (scipy, pys2index, etc.).

Configs look good to me. Feel free to merge whenever it suits you.

benbovy commented 3 years ago

Great, thanks.