search

xarray-contrib / xskillscore

Metrics for verifying forecasts
https://xskillscore.readthedocs.io/en/stable/
Apache License 2.0
222 stars 38 forks source link

mu scalars / sig scalars in probabilistic fail #13

Closed ahuang11 closed 5 years ago

ahuang11 commented 5 years ago

Docs state scalars are ok

    mu : Dataset, DataArray, GroupBy, Variable, numpy/dask arrays or
     scalars, Mix of labeled and/or unlabeled forecasts mean arrays.
    sig : Dataset, DataArray, GroupBy, Variable, numpy/dask arrays or
     scalars, Mix of labeled and/or unlabeled forecasts mean arrays.

However, 

/mnt/c/Users/Solactus/GOOGLE~1/Bash/xskillscore/xskillscore/core/probabilistic.py in xr_crps_gaussian(observations, mu, sig)
     27     """
     28     # check if same dimensions
---> 29     if mu.dims != observations.dims:
     30         observations, mu = xr.broadcast(observations, mu)
     31     if sig.dims != observations.dims:

AttributeError: 'int' object has no attribute 'dims'

Probably need to do if not isinstance(mu, xr.DataArray): mu = xr.DataArray(mu)

raybellwaves commented 5 years ago

Thanks for the bug report @ahuang11. @aaronspring are you ok to work on this?

raybellwaves commented 5 years ago

Closed via https://github.com/raybellwaves/xskillscore/pull/14