xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.
https://xwrf.readthedocs.io/
Apache License 2.0
56 stars 16 forks source link

Added earth-relative wind field calculation to base diagnostics #100

Closed lpilz closed 1 year ago

lpilz commented 1 year ago

Change Summary

This might not be the best way to implement this, but I think we should also include earth-relative wind field calculation if we already have the other diagnostics. What are your opinions?

Checklist

PS:

For me, locally, this change causes the test tests/test_accessors.py:15 test_postprocess[lambert_conformal-lambert_conformal_conic] to fail, though I think this is an unrelated bug. However, I don't know enough about cf_xarray to debug this.

The error is:

>       assert 'z' in standard_names['atmosphere_hybrid_sigma_pressure_coordinate']                                                                                                            
E       AssertionError: assert 'z' in ['z_stag']                                                                                                                                               
lpilz commented 1 year ago

I think I'll merge pursuant to your and @andersy005's review. Thanks, guys!