Changed wrfout file (cf. xwrf-data/#34)

xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.

https://xwrf.readthedocs.io/

Apache License 2.0

56 stars 16 forks source link

Changed wrfout file (cf. xwrf-data/#34) #102

Closed lpilz closed 1 year ago

lpilz commented 1 year ago

Change Summary

Cf. xwrf-data/#34

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable

jthielen commented 1 year ago

Will this require any updates to the tutorial documentation (which looks to be the only existing location this is used)?

lpilz commented 1 year ago

I'm working through the tutorials now, updating them wrt the destagger and the earth-rel wind variables. So yes, but it's being worked on.

I expect this change not to break any tests or tutorials by itself, but I'll retrigger CI once xwrf-data/34 is merged

jthielen commented 1 year ago

@lpilz Would you be able to confirm that https://xwrf--102.org.readthedocs.build/en/102/index.html looks like you'd expect with the updated "wrfout" tutorial dataset? If yes, then this should be good to merge!

jthielen commented 1 year ago

@lpilz Would you be able to confirm that https://xwrf--102.org.readthedocs.build/en/102/index.html looks like you'd expect with the updated "wrfout" tutorial dataset? If yes, then this should be good to merge!

Sorry to go back on this! I realized with #106 that having merged https://github.com/xarray-contrib/xwrf-data/pull/34 without this breaks CI. So, I need to merge this now no matter the state of the docs. Hopefully your tutorial updates will fix anything that breaks (if anything) because of this.