xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.
https://xwrf.readthedocs.io/
Apache License 2.0
56 stars 16 forks source link

Updated accessors.py #115

Closed vedant-gawande closed 1 year ago

vedant-gawande commented 1 year ago

Just did some small assignment task to remove this small error of walrus operator(:=) which will make the module xwrf run even in unupdated versions of python solving the import error

Change Summary

Related issue number

Checklist

jthielen commented 1 year ago

Thank you for offering this contribution! However, Python versions older than 3.8 are not being supported by most of the community (see NEP 29 already at 3.8 minimum and conda-forge dropping 3.7 in the coming days), which means that xwrf trying to support such outdated Python versions would be an undue maintenance burden (e.g., custom CI builds, increased complexity in dependency management). So, with xwrf only supporting Python >= 3.8, this PR's change is unfortunately not worthwhile. If you are currently using Python <= 3.7, I highly encourage you to focus your efforts on modernizing your environment (be it yourself or working with a sysadmin) to regularly update and keep pace with the present Scientific Python community (for example, in about 6 months, many packages will have Python 3.9 as their minimum version).

vedant-gawande commented 1 year ago

Understood! so it is plausible to close the issue : SyntaxError encountered upon import #114 as in newer versions walrus operator is supported so no error while importing xwrf.

jthielen commented 1 year ago

Understood! so it is plausible to close the issue : SyntaxError encountered upon import #114 as in newer versions walrus operator is supported so no error while importing xwrf.

Correct, we are just waiting for a response from the issue's author to verify that was indeed their issue prior to closing.