Closed lpilz closed 1 year ago
There are some units which I didn't quite know how to translate:
W/m.K
)
W m-1 K-1
or W K m-1
?m/s * area
)
m3 s-1
or m-1 s-1
or even kg m2 s-1
or kg s-1 m-2
?Small ping on this PR :)
As far as the units of uncertain translation go:
savedtke12d
with W/m.K
: given how it is used in https://github.com/wrf-model/WRF/blob/master/Registry/registry.lake, I'd say match the thermal conductivity values elsewhere in the same registry...so W m-1 K-1
. maxMF
with m/s * area
: given how it is used in https://github.com/wrf-model/WRF/blob/v4.2/phys/module_bl_mynn.F, it is the product of edmf_a
(unit -
which becomes dimensionless) and edmf_w
(m s-1
), which weirdly enough implies that it should be m s-1
. I'm not too concerned about getting this perfectly right, as I'd hope that anybody digging that much into the weeds of the MYNN-EDMF scheme knows what they are doing to be able to properly use that field.Hey, happy holidays! Sorry for the long delay on my part now... Didn't have too much time to spend on this until now due to AGU.
I added the changes, however I don't quite know what you would like to see here.
add new tests for each of the new categories of units handled in the expanded
unit_harmonization_map
What are the new categories you're referring to?
Small ping here :)
Thanks for the ping on this, and sorry for the very long delay! Unfortunately I'm a bit swamped with prelim-related stuff at the moment, so I won't be able to get back to this until next week. But, hopefully will be able to then.
Hey :) just a small reping. If and whenever you find the time of course!
Hey @jthielen, I'm just going to go ahead and merge this if you don't mind.
Hey @jthielen, I'm just going to go ahead and merge this if you don't mind.
Yes, please go ahead! Sorry for my continued inattentiveness. Hopefully things will be getting better soon.
Change Summary
Unit harmonization is improved by:
Related issue number
Checklist