Adding CF metadata - Githubissues

xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.

https://xwrf.readthedocs.io/

Apache License 2.0

59 stars 16 forks source link

Adding CF metadata #33

Closed lpilz closed 2 years ago

lpilz commented 2 years ago

Change Summary

This is work towards adding CF metadata to xwrf

Related issue number

Closes #15

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI
[ ] Documentation reflects the changes where applicable

Changes still in development:

[x] Add custom dictionary option to backend

lpilz commented 2 years ago

Do any of you have comments regarding using a yaml file to store this information? It seemed intuitive to me, but is this good form?

lpilz commented 2 years ago

Hi everyone, so I had a bit of time and implemented the configuration in donfig. First of all, I hope I am using the package correctly. I'm not terribly experienced with dask configurations, so please correct me if I should have done it differently :)

Secondly, I simply implemented a preliminary structure into the yaml file which is probably not ideal. If any of you have ideas on how to improve this, they are very welcome!

lpilz commented 2 years ago

Cheers for the review, I just added the changes you requested :)

andersy005 commented 2 years ago

Cheers for the review, I just added the changes you requested :)

Great 👍🏽! Is this ready to transition from draft to a ready PR or are you still planning to add more work to it?

lpilz commented 2 years ago

I think it's ready for merging if you are satisfied :+1:

lpilz commented 2 years ago

If we think of any way to improve this in the future, we can just open new PRs I guess

jukent commented 2 years ago

Thanks for putting this together!