search

xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.
https://xwrf.readthedocs.io/
Apache License 2.0
59 stars 16 forks source link

Furo theme Xarray styling is bad on non-chromium browsers #73

Closed kmpaul closed 2 years ago

kmpaul commented 2 years ago

What is your issue?

The styling fix implemented for Xarray HTML reprs when used with the Furo Sphinx theme only works for Chrome. It needs further investigation for Safari and Firefox browsers.

kmpaul commented 2 years ago

Turns out the fix for this was very easy. The hack I implemented initially in #72 implemented a function that assigned a value to a const, which should not be allowed. Turns out Chrome was a bit forgiving, while Safari and Firefox were not. Thus, I just changed the problem variable from a const to a var and it now works in Chrome, Safari, and Firefox.

kmpaul commented 2 years ago

Note that this should be closed and the hack should no longer be needed when a new release of Xarray is minted.

kmpaul commented 2 years ago

I'm going to close this now and point to #74 when the next Xarray release is minted.