Fixed missing dependencies from CI

xarray-contrib / xwrf

A lightweight interface for working with the Weather Research and Forecasting (WRF) model output in Xarray.

https://xwrf.readthedocs.io/

Apache License 2.0

56 stars 16 forks source link

Fixed missing dependencies from CI #75

Closed lpilz closed 2 years ago

lpilz commented 2 years ago

Change Summary

Added cf_xarray to upstream dev environment so test/test_accessors.py:9 runs, which promptly returned an error. Fixed the variable name in the test.

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI

lpilz commented 2 years ago

@andersy005 can you explain what the difference between ci/environment.yml and ci/environment-upstream-dev.yml is? I always thought the first one is for deployment and the second one for internal CI, but these tests seem to use ci/environment.yml.

andersy005 commented 2 years ago

can you explain what the difference between ci/environment.yml and ci/environment-upstream-dev.yml is? I always thought the first one is for deployment and the second one for internal CI, but these tests seem to use ci/environment.yml.

we have a nightly CI workflow that uses the ci/environment-upstream-dev.yml

https://github.com/ncar-xdev/xwrf/blob/main/.github/workflows/upstream-dev-ci.yaml

This workflow doesn't get triggered on PRs and pulls though. It runs once a day at midnight UTC (e.g. https://github.com/ncar-xdev/xwrf/actions/runs/2186844226)

lpilz commented 2 years ago

Ah, so the idea of the -upstream-dev.yml is to anticipate breaking changes in dependencies, while the environment.yml is used for the CI and the dependencies for deployment are in the requirements.txt?

andersy005 commented 2 years ago

Ah, so the idea of the -upstream-dev.yml is to anticipate breaking changes in dependencies, while the environment.yml is used for the CI and the dependencies for deployment are in the requirements.txt?

Exactly!