Closed lpilz closed 2 years ago
The latest xgcm dropped support for 3.8
Ah, that's a good explanation. Should we then restrict the xgcm
version to the one before the new or can we do this smarter somehow? Shouldn't conda take care of this if we don't explicitly depend on the newest xgcm
?
Well, xwrf doesn't depend on xgcm, just the tests, right? If that's true, then I would skip the xgcm test if the python version is 3.8. Use something like @pytest.mark.skipif(pyversion == 3.8, reason="xgcm doesn't work with Python 3.8")
. But checking the python version needs to be done right.
Actually, it looks like xgcm now only works with python version >=3.9, which means you can mark the xgcm test(s) like so:
from sys import version_info
@pytest.mark.skipif(version_info < (3, 9), reason="xgcm only works with Python 3.9+")
def test_xgcm():
...
https://github.com/xgcm/xgcm/issues/484#issuecomment-1105344303
It's just a bad conda yaml
Fixed in #70
What happened?
Currently, the CI breaks on
main
, as for some reason the typing library being shipped with python 3.8 is so old that it doesn't support theget_type_hints(include_extras=True)
kwarg. It seems to me like this might be a problem withxgcm
's dependenciesMinimal Complete Verifiable Example
No response
Relevant log output
No response
Environment
Anything else we need to know?
No response