search

xat / chromecast-scanner

scan your local network for chromecast devices and return the first found
MIT License
27 stars 11 forks source link

changed to mdns-js v0.2.x #1

Closed kmpm closed 9 years ago

xat commented 9 years ago

Thanks very much! I also tried to use mdns-js at first, but it threw some errors which I don't remeber exactly anymore, that's why I went with mdns-js2. I'll gladly switch to mdns-js :-)

The intention of the lib was to only return the first chromecast found in the network from which you optionally know it's name. I needed this particularly behaviour within my chromecast-player module. So I think we should stop the browser right away after the first (matching) device was found otherwise the callback would get called multiple times. Or do you see any drawbacks?

kmpm commented 9 years ago

The only drawback with that that I can see is that if you have 2 devices you can never be certain of which one answers first but I see your dilemma if you are handing over this to another library.

I can change back later or if you wan't to do it yourself, that's fine. I don't have access to a computer where I can fix it right now but if it isn't fixed later today then I'll have a go.

xat commented 9 years ago

okay, thx, I'll change it :)