search

xataio / pgroll

PostgreSQL zero-downtime migrations made easy
https://www.xata.io
Apache License 2.0
3.56k stars 67 forks source link

Add support for `onDelete` reference #296

Closed SferaDev closed 8 months ago

SferaDev commented 8 months ago

Fixes #221

@andrew-farries I'm not sure if you finally implemented it, If you have something in the works please close this PR as yours will likely be better than mine.

The enum parsing could be way better, but omissis/go-jsonschema doesn't generate much without going all-in with their validator, and even with that it's behind enumer or validator. I decided to manually check for the values, but I'd be fine with not checking it at all or adding some better enum validator.

SferaDev commented 8 months ago

Closing in favour of #297

andrew-farries commented 8 months ago

Hi @SferaDev, thanks for doing this 🙏 . I was also working on this and have opened https://github.com/xataio/pgroll/pull/297 to do it.

It's basically the same as what we have here but also updates examples and the docs too. Mind if we close this?

andrew-farries commented 8 months ago

haha, beat me to it 😆