This MR brings improvments to the CppCAN::analysis::is_frame_layout_ok functions as now it successfully supports both Big Endian and Little Endian signals (as described in DBC files).
This DBC specification does not seem to be an official one and seem to be wrong about the way one should parse the signals' endianness. I preferred following the examples of this library and cantools: 1 for Little Endian and 0 for Big Endian.
I also added the CHECKFRAME operation to can-parse. It was advertised on the README and the help command but wasn't implemented. Now it's present and can report layout errors ! Yay !
This MR brings improvments to the
CppCAN::analysis::is_frame_layout_okfunctions as now it successfully supports both Big Endian and Little Endian signals (as described in DBC files).This DBC specification does not seem to be an official one and seem to be wrong about the way one should parse the signals' endianness. I preferred following the examples of this library and cantools:
1for Little Endian and0for Big Endian.I also added the CHECKFRAME operation to can-parse. It was advertised on the README and the help command but wasn't implemented. Now it's present and can report layout errors ! Yay !