Merge interesting changes in the Wolox new release?

[jcabot]

https://github.com/Wolox/react-chat-widget/releases/tag/v3.0.0

(take a look and decide whether there is anything that it should be worth porting back to xatkit)

[hamzaed]

The new version provides a fix to the issues #38 #34 and includes some general improvements (e.g., timestamp below each message)

[jcabot]

Sounds good to me but I let to you and to @gdaniel to decide on how to proceed (by just reimplementing the code using wolox's release as inspiration, trying to more directly merge some of their commits,... or just nothing and do our own thing). The technicalities of these options escape my area of confort :-)

[hamzaed]

I created a branch called merge-rcw-v3 where I pulled and merged their last changes. Resolving the conflicts was not efficient to integrate their last changes because they migrated to TypeScript and all Javascript files have been modified and now have a new extension (we have both our customized JS files and the new tsx files).

To be continued.

Hamza

[jcabot]

So, to make sure I understand, you will indeed incorporate some of the changes to our widget?

[hamzaed]

Yes, I'm trying to incorporate ALL the changes. However this is major update. We have so many conflicts because we touched many components and we modified all the css sources (adding xatkit prefix). Plus everything is written in TypeScript now (so we need to adapt our changes to TypeScript style) so we can't just take one feature and add it to our widget.

[gdaniel]

Jumping on the conversation: @hamzaed also told me that they renamed all the .js files to .ts with the switch to Typescript. This messes up the git diff results and complicates the merge.

[jcabot]

Ok, so maybe we can just drop this merge.

Again, if we see a feature we really like we reimplemented, at most, getting some inspiration looking at how they did it but I don't see enough value in wasting too many hours porting their changes if it takes us too much time

[hamzaed]

Noted