search

xatkit-bot-platform / xatkit-chat-widget

(React) Chat widget for Xatkit
https://xatkit.com
MIT License
6 stars 2 forks source link

Rename the minified files? #46

Closed jcabot closed 4 years ago

jcabot commented 4 years ago

I would say we should call then xatkit.min.js and xatkit.min.css, no?

hamzaed commented 4 years ago

I think that renaming the files this way suggests that we also have the non-minified versions which is not true. These files are the result of transpiling and bundling the sources.

jcabot commented 4 years ago

Not sure. To me, a min file means that the result of whatever budle process is minified, not necessarily that the minified file is the direct minification of an equivalent single source code file (but I will not insist)

hamzaed commented 4 years ago

Now the minified bundles are called xatkit.min.js and xatkit.min.css