search

xatkit-bot-platform / xatkit-chat-widget

(React) Chat widget for Xatkit
https://xatkit.com
MIT License
6 stars 2 forks source link

Clarifying hostname, url, origin #59

Closed jcabot closed 4 years ago

jcabot commented 4 years ago

When rendering the widget you can pass the following parameters: hostname, url, origin.

It's not clear in the readme what is the meaning of each parameter (even one of them is missing in the explanation table).

Also, can you review that each parameter is then mapped to the right internal value? When testing the WP plugin I passed the post full URL to the "url" parameter but on the bot side I had to recover it from the hostname one. It could just be that the order of the parameters in my version of the widget is outdated but please doublecheck.

hamzaed commented 4 years ago

I added the missing parameter and also a example for each parameter to clarify the meaning.

I'll check that each parameter is then mapped to the right internal value.

jcabot commented 4 years ago

Did you complete the check? Did you find an error?

hamzaed commented 4 years ago

I couldn't find any problem. Are you using the last version of the widget (with the JSON object as args)?

jcabot commented 4 years ago

Nope. That was done with the old version. I'll retest with the new one and see if everything looks fine