xatkit-bot-platform / xatkit

The simplest way to build all types of smart chatbots and digital assistants
https://xatkit.com
Eclipse Public License 2.0
176 stars 23 forks source link

Xatkit cannot be built with JDK9, 10, and 12 #6

Open gdaniel opened 6 years ago

gdaniel commented 6 years ago

These JDKs introduce Modules, that are defined in java.lang.module, and conflict with Xatkit Modules. In addition, the build prints several warning related to illegal reflective accesses from xcore and xtext.

gdaniel commented 6 years ago

Support for JDK9 and JDK10 is left for a future release (current release: v1.0.0).

gdaniel commented 6 years ago

This support implies to rename module packages and classes, and handle illegal reflective calls

gdaniel commented 5 years ago

This needs to be check after the renaming of Module-related classes to Platform (see xatkit-bot-platform/xatkit-runtime#172)

gdaniel commented 5 years ago

This issue has been reported by @nadiana18 after the Xatkit tutorial, relevant part of the log provided below. Java version: 12 OS: macos

[INFO] --- xtext-maven-plugin:2.9.2:generate (default) @ common ---
[INFO] Encoding: UTF-8
[INFO] Compiler source level: 1.8
[INFO] Compiler target level: 1.8
[INFO] Using common types.
[INFO] Collecting source models.
[INFO] Installing type provider.
[INFO] Generating stubs into [...]
[INFO] Compiling stubs located in [...]
[INFO] Installing type provider for stubs.
[INFO] Validate and generate.
[ERROR] resource is empty: java:/Objects/java.lang.Object
java.lang.IllegalStateException
at org.eclipse.xtext.common.types.access.impl.AbstractClassMirror.getEObject (AbstractClassMirror.java:93)
at org.eclipse.xtext.common.types.access.TypeResource.getEObject (TypeResource.java:90)
at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.getEObject (ResourceSetImpl.java:223)
at org.eclipse.emf.ecore.util.EcoreUtil.resolve (EcoreUtil.java:213)
at org.eclipse.emf.ecore.util.EcoreUtil.resolve (EcoreUtil.java:269)
at org.eclipse.xtext.common.types.access.TypeResource.resolveJavaObjectURIProxy (TypeResource.java:169)
at org.eclipse.xtext.common.types.impl.JvmTypeReferenceImplCustom.eResolveProxy (JvmTypeReferenceImplCustom.java:32)
at org.eclipse.xtext.common.types.impl.JvmParameterizedTypeReferenceImpl.getType (JvmParameterizedTypeReferenceImpl.java:111

This issue seems to be related. The discussion mention Java 10 support from Tycho, there is maybe a plugin dependency to upgrade.

gdaniel commented 4 years ago

Also related to https://github.com/xatkit-bot-platform/xatkit-runtime/issues/250