xatupal / KeeTheme

KeePass Plugin
MIT License
457 stars 36 forks source link

Font Color & Size Make Fonts Hard to Read #31

Closed koolx closed 3 years ago

koolx commented 4 years ago

The font is grey and hardly readable. Please color them white and enlarge it.

aFooBar commented 4 years ago

Why all the Dark themes give the impression the applications are bub off/washed out :/ Having a more blackished theme would definitively increase readability

bendover22 commented 4 years ago

I haven't installed the dark KeeTheme yet, but if the screens are a good representation, I have to agree. Some of the disabled fonts are barely visible. I have some moderate vision issues & I need fairly good contrast.

Though disabled text / options are supposed to be less bright, you still need to be able to read them. Sometimes things are disabled when they shouldn't be. Or you may want to find how to activate some disabled options.

xatupal commented 4 years ago

There are various guidelines for dark theme designs. One of them is that you shouldn't use white fonts on a black background, but if you need better contrast, I recommend using a theme created by @BradyThe - DarkenKP.

As for disabled controls, my hands are tied. Disabled control is drawn by the operating system based on colors of the active control. I will see if any hack is possible to draw it better.

koolx commented 4 years ago

One of them is that you shouldn't use white fonts on a black background, but if you need better contrast, I recommend using a theme created by @BradyThe - DarkenKP.

Who the hell said white font on black background isnt a good idea?? Whoever said that doesnt know what he's talking about.

madmax2 commented 4 years ago

@xatupal just look at your own windows explorer in Windows 10 when you enable dark theme.. it is using white text on a dark background..

Your dark theme is pretty useless since it is very hard to read the text. Please fix this.

Whichever guideline/s you got this idea from is wrong or outdated.

Darthagnon commented 4 years ago

I came here, as I find the default theme unusable, due to the dark grey text on a darker grey background. I am 25 and have good eyesight, and it's all but illegible. Since this plugin supports custom themes, does anyone know which fields of the custom theme INI affect text colour? There's so many of them.

EDIT: @madmax2, @koolx, @aFooBar, here's an edited version of the default theme: https://github.com/Darthagnon/keepass-better-dark-theme/

Text is now legible, alternating row colours are now visible (but still subtle), and settings URLs are red (done on a whim; you can change it back if you want. URLs in Notes are still too dark, but afaik those cannot be customised). I added comments on what sections I identified to be what.

xatupal commented 3 years ago

You were right. Contrast ratio between background and text was too low. I've increased it to the proper level. Old ratio: 3.81, new ratio: 7.09

@Darthagnon thanks for the great theme!