search

xaukael / griddy

MIT License
3 stars 1 forks source link

Incompability with A5e (and possibly more) systems #2

Closed joeundsoo closed 10 months ago

joeundsoo commented 10 months ago

Hello there, great idea for a module! Sadly, I've run into a compability problem with the system I am using. I'm using the most recent Foundry Build (315) and A5e Version (0.16.15). Neither clicking on Inventory Grid or Griddy in the character sheet opens the Griddy Menu and an error message is sent to the console. image

The system dev looked into it: image After modifying the module, the Griddy Menu opens. Items are displayed correctly inside the grid and so on. But when it comes to changing the properties of an item (making it take more squares, turning it into a container..), the button for that setting still isn't portrayed in the item sheet.

The dev mentioned, that the way of getting the actor could be more robust, because of the coming appv2 in Foundry v12. image The A5e system for example doesn't use handlebars, but svelte.

I don't know how to code myself, so I don't know how difficult it would be to provide a better compability...

If there's anything else needed for a possible fix, I'm glad to help!

xaukael commented 10 months ago

Remove quotes on the item types settings.

Fixed the sheet header buttons using app.object/app.document in 1.0.8. Thank you so much for the heads-up.

joeundsoo commented 10 months ago

Great, the grid works now, thank you! But I've run into another problem: image The Position button opens the menu, but it is empty. Also in an otherwise unmodded world.

xaukael commented 10 months ago

That is odd. Any errors?

xaukael commented 10 months ago

Nevermind, I missed some app.object references. should be fixed in 1.0.9

joeundsoo commented 10 months ago

Yes, that's it. Awesome, it's working. Thank you so much for the quick fixes!

xaukael commented 10 months ago

going on holiday for 5 days starting tomorrow. Trying to not have to think about it too much while gone