xavier-b / RMaps-xavPatch

A fork from RMaps project
11 stars 6 forks source link

Banned from OSM #5

Open kevsgithub opened 3 years ago

kevsgithub commented 3 years ago

Rmaps and many other apps have been banned from OpenStreetMaps due to generic Useragent and incorrect usage of cache control. User agent must contain the app name.

Useragent should probably be the Android device and rmaps version, eg : Samsung s4 mini - RMaps.0.9.4.1-xavPatch.1

I've had a quick skim of the source code and found these : https://github.com/xavier-b/RMaps-xavPatch/blob/440673293290615d3a741e7e5f20d35e192e9bd3/RMaps.AppLib/src/com/robert/maps/applib/downloader/FileDownloadListActivity.java#L98

This force skip of OSM cache is just wrong on so many levels, no wonder apps like this have been banned. https://github.com/xavier-b/RMaps-xavPatch/blob/440673293290615d3a741e7e5f20d35e192e9bd3/RMaps.AppLib/src/com/robert/maps/applib/downloader/FileDownloadListActivity.java#L97

Thanks for maintaing rmaps for the very few of us who still think it's the best :) :+1:

kevsgithub commented 3 years ago

There have been warning signs for this for quite a while. https://github.com/xavier-b/RMaps-xavPatch/issues/4