search

xavierd / clang_complete

Vim plugin that use clang for completing C/C++ code.
http://www.vim.org/scripts/script.php?script_id=3302
1.96k stars 308 forks source link

WIP: Add basic deoplete hooks. #461

Closed expipiplus1 closed 9 years ago

expipiplus1 commented 9 years ago

Closes #460

I've not written any Python for a long time, and don't really know anything about the internals of deoplete or clang_complete however this seems to work very well in my limited testing. I'm sure that @Shougo has some useful things to say about this.

xaizek commented 9 years ago

What's rplugin/ directory and why sub-directory is saying python3? I thought that clang_complete doesn't work with python3 (but there were necessary changes in one of forks).

Also, deoplete seems to be something for neovim, does this mean that clang_complete works there? (Just checking, because those guys like to break things and I wouldn't be surprised if the plugin doesn't work there.)

expipiplus1 commented 9 years ago

rplugin stands for remote plugin I think. there's some documentation here: https://neovim.io/doc/user/remote_plugin.html

This is kind of like a meta-plugin for deoplete.

Although this is written in python3, it interfaces with the python2 code via vimscript :/ I'm sure it would be a little bit nicer if clang_complete was written in python3 too, and could be called directly.

Yes, this is for Neovim. Pretty much every plugin I use has worked with Neovim out of the box, clang_complete is no exception. This just makes the interface with deoplete a bit nicer, and consistent with other plugins.

xaizek commented 9 years ago

Thanks for the explanation, if the plugin is run in a separate process, it explains why it would work.

Seems harmless yet might be useful for someone, so I'm merging this, thanks.

expipiplus1 commented 9 years ago

You're welcome.

I think it would be best to have someone who understands the deoplete side of things to take a look at this at some point.

Shougo commented 9 years ago

Thanks. I have reviewed it.

expipiplus1 commented 9 years ago

Thanks!