xavierdidelot / BactDating

Bayesian inference of ancestral dates on bacterial phylogenetic trees
https://xavierdidelot.github.io/BactDating
MIT License
81 stars 15 forks source link

Adds drop.tip.useRec for trees with rec information #13

Closed johnlees closed 5 years ago

johnlees commented 5 years ago

Uses ape function. Closes #12

johnlees commented 5 years ago

I don't have much experience with R packaging, but I ran devtools::install() followed by devtools::document() on the changes to autogenerate the man etc, and all seemed ok. I would still appreciate a quick check to see if it looks alright though!

johnlees commented 5 years ago

Perhaps there is a better naming convention for the internal C function I lifted over too?

xavierdidelot commented 5 years ago

will try to fix

xavierdidelot commented 5 years ago

Hi John,

I have accepted your pull request and made a few changes to avoid errors/warnings. I think it should all work fine, but let me know if not. Thanks again!

Xavier

johnlees commented 5 years ago

Thank you Xavier, and sorry for the errors!