xavierdidelot / BactDating

Bayesian inference of ancestral dates on bacterial phylogenetic trees
https://xavierdidelot.github.io/BactDating
MIT License
80 stars 15 forks source link

Question–– model selection with pstrict vs. other criteria? #69

Closed amyecampbell closed 3 months ago

amyecampbell commented 3 months ago

Hello!

I tested strictgamma, mixedgamma, and arc on my dataset, which had a good linear root-to-tip fit, using a fixed root (known based on larger phylogenetic analysis of this clade). For example, I called:

_bactdate(tree ,dateinfobact,nbIts=1e8, model="mixedgamma",showProgress = T, updateRoot = F)

All the ESS values were high as shown in the table (I used default thinning), and then DIC was lowest for strict gamma by more than the DIC difference between arc and mixedgamma. However, the pstrict for the mixedgamma result was 0. I'm wondering if you have any thoughts on how I should move forward given that?

Thank you very much for this tool. Any thoughts you have would be appreciated.

Screenshot 2024-05-21 at 2 03 25 PM
xavierdidelot commented 3 months ago

If pstrict in mixedgamma is zero then it means that relaxing the clock helps explain the data. If you want a DIC-based equivalent of this then you should compare the DIC for the strictgamma and relaxedgamma models, since the mixedgamma model is a mix of these two models. It is probably best to avoid comparing continuous models (like strictgamma, relaxedgamma and mixedgamma) with discrete models (like arc). The continuous equivalent of arc is called carc. The discrete equivalents of strictgamma and mixedgamma are poisson and negbin, respectively.

amyecampbell commented 3 months ago

Thank you!