search

xavierlacot / joli.js

joli.js is an Activerecord-like javascript ORM, particularly suited for being used in the Appcelerator Titanium Mobile framework.
MIT License
267 stars 60 forks source link

jslint errors #7

Closed mattheworiordan closed 12 years ago

mattheworiordan commented 13 years ago

Hi Xavier

Love your library, thanks.

One small issue I have when using Joli is that the Javascript does not pass the JSLint set of tests, whereas all my other code does. I realise this is not necessarily an error, but it is advisable to conform to JSLint generally. Here are the errors that come up with JSLint and Joli.js http://www.pastie.org/2196158

Would you be willing to make the necessary changes? If not, would you be willing to merge in the changes if I go ahead and do that?

xavierlacot commented 13 years ago

Hi Matthew,

joli.js is compatible with the jshint.com validation, but not with the JSLint one, which is slightly more strict. I am not sure if it is really useful to conform to JSLint, and the changes proposed by JSLint will help a lot, but go ahead if you feel so, and I'll merge your changes if they do not have any impact on the code's performance.

Thanks a lot,

mattheworiordan commented 13 years ago

Hey Xavier. Ok, happy to go ahead and try. However, been chatting with Aroldan who created a full CRUD fork and think I will create a JSLint compatible version of that instead. Joli is great, but without the U in CRUD it's not ideal for me. Are you willing to incorporate Aroldan's changes?

mattheworiordan commented 13 years ago

Woops Xavier, just read your email and seen your last commit, and it seems you have included a solution where the U in CRUD is possible. I see you've also fixed a few of the issues with JSLint compatibility. I'll try out this version now, and if it works I'll fork and create a JSLint compatible version which you can incorporate if you wish. Thanks for the U update, greatly appreciated.

xavierlacot commented 13 years ago

You're welcome :)

cheers,

Xavier

On Tue, Jul 12, 2011 at 10:37 AM, mattheworiordan < reply@reply.github.com>wrote:

Woops Xavier, just read your email and seen your last commit, and it seems you have included a solution where the U in CRUD is possible. I see you've also fixed a few of the issues with JSLint compatibility. I'll try out this version now, and if it works I'll fork and create a JSLint compatible version which you can incorporate if you wish. Thanks for the U update, greatly appreciated.

Reply to this email directly or view it on GitHub: https://github.com/xavierlacot/joli.js/issues/7#issuecomment-1552771

Xavier Lacot xavier@lacot.org http://lacot.org/