search

xavierlaffargue / m3u8parser-csharp

M3U8Parser makes it easy to read, edit and create a m3u8 file.
https://www.nuget.org/packages/M3U8Parser/
MIT License
4 stars 2 forks source link

Bug: closed-caption NONE unsupported #1

Open xavierlaffargue opened 1 year ago

xavierlaffargue commented 1 year ago

CLOSED-CAPTIONS

  The value can be either a quoted-string or an enumerated-string
  with the value NONE.  If the value is a quoted-string, it MUST
  match the value of the GROUP-ID attribute of an EXT-X-MEDIA tag
  elsewhere in the Playlist whose TYPE attribute is CLOSED-CAPTIONS,
  and it indicates the set of closed-caption Renditions that can be
  used when playing the presentation.  See [Section 4.3.4.2.1](https://www.rfc-editor.org/rfc/rfc8216.html#section-4.3.4.2.1).

  If the value is the enumerated-string value NONE, all EXT-X-
  STREAM-INF tags MUST have this attribute with a value of NONE,
  indicating that there are no closed captions in any Variant Stream
  in the Master Playlist.  Having closed captions in one Variant
  Stream but not another can trigger playback inconsistencies.
ricwar commented 3 months ago

Hi Xavier! Do you have any idea when this 'bug' will be fixed? We're currently using our own extensionmethod based on the MasterPlaylist.ToString() in order to fix this but we would very much like to remove that extension from the project. BR Richard @ Papirfly

xavierlaffargue commented 3 months ago

I'll try this month, but PR are always welcome 😀

ricwar commented 3 months ago

Hi Xavier, I do have a PR for you - if you want? But then I need access to create- and push a new branch, of course :)

xavierlaffargue commented 3 weeks ago

@ricwar You need to create a Fork and after a pull request here from your fork to main :)