search

xavierleroy / camlidl

Stub code generator for OCaml/C interface
Other
34 stars 8 forks source link

Detect .so/.dll in case of a mingw build #10

Closed yakobowski closed 5 years ago

yakobowski commented 5 years ago

On a Mingw build, dynamic libraries have a .dll extension. Detect this accordingly.

I'm aware of the Makefile.win32/Makefile.unix distinction, but the Unix Makefile works perfectly for a Cygwin+Mingw build. It feels wasteful to create a third Makefile just for this. I believe this approach would signficantly reduce the size of https://github.com/fdopen/opam-repository-mingw/blob/master/packages/camlidl/camlidl.1.05/files/camlidl-1.05.patch

yakobowski commented 5 years ago

This is not really relevant after https://github.com/fdopen/opam-repository-mingw/commit/b2f33775cc52ba362d566552c843b1ef09465edd, so I will close this PR. Sorry for the noise.