search

xavierleroy / camlidl

Stub code generator for OCaml/C interface
Other
34 stars 8 forks source link

fixes and extensions #13

Closed phi-gamma closed 4 years ago

phi-gamma commented 4 years ago

This is a collection of bugfixes and some MIDL specific additions that I needed to process certain IDL definitions from Samba.

I hope it’s ok to lump these together into a single PR as the commits should be self-contained.

xavierleroy commented 4 years ago

Thank you very much for this PR. CamlIDL has been dormant for a while, so it's nice to see external contribution.

I had a quick look at the changes and they look good to me.

Perhaps @jakoblichtenberg could have a look as well? If he's not available I'll merge in a couple of weeks.

jakoblichtenberg commented 4 years ago

I did not do a code review, but I imported the feature branch into our ingestion system. Was able to build all our products. Was able to run our standard OCaml ingestion tests. No issues discovered.

xavierleroy commented 4 years ago

Thank you very much, @jakoblichtenberg , for the independent testing. Time to merge!

phi-gamma commented 4 years ago

Thank you!