Fix proxy display - Githubissues

xavierog / moulti

Moulti is a CLI-driven Terminal User Interface (TUI) displaying arbitrary outputs inside visual, collapsible blocks called steps.

MIT License

112 stars 4 forks source link

Fix proxy display #8

Closed kyokley closed 2 months ago

kyokley commented 2 months ago

I think this fixes #7. At the very least, I was able to get it to run. However, I'm guessing that since Ansible moved proxy_display under Display and renamed it to _proxy, it may not be safe to depend on it 🤷

xavierog commented 2 months ago

Thank you very much. I will have a look later this day. Most likely, I will adjust the code so as to handle both Ansible >= 2.17 and Ansible < 2.17 (we cannot assume that everyone is always running the latest version of Ansible).

However, I'm guessing that since Ansible moved proxy_display under Display and renamed it to _proxy, it may not be safe to depend on it 🤷

Indeed, the leading _ reflects this decorator should be considered private. We can still use it though, provided we accept the burden of updating Moulti each time this private decorator changes in a breaking way.

kyokley commented 2 months ago

Thank you very much. I will have a look later this day. Most likely, I will adjust the code so as to handle both Ansible >= 2.17 and Ansible < 2.17 (we cannot assume that everyone is always running the latest version of Ansible).

Ah, right, of course. Feel free to close this.

By the way, the output looks really nice. Thanks for the plugin!

xavierog commented 2 months ago

I am going to squash, edit and merge your changes manually and close this pull request. My changes are merely boilerplate (changelog, documentation, comments). Of course, you remain the author of the resulting commit.

This issue prompted me to test Moulti against multiple versions of ansible. Here are the results:

2.17 -- works thanks to your changes
2.16 -- works
2.15 -- does not work: ERROR! Unexpected Exception, this is probably a bug: type object 'Display' has no attribute '_proxy'
2.14 -- does not work: ERROR! Unexpected Exception, this is probably a bug: type object 'Display' has no attribute '_proxy'

I will check later whether Moulti can afford to support ansible-core 2.14 (even though it is EOL) and 2.15.

xavierog commented 2 months ago

@kyokley Your contribution is now available publicly as part of Moulti v1.12.1. Thanks for your work!