search

xaviershay / consul-client

Ruby client gem for Consul HTTP API.
42 stars 7 forks source link

warning: circular argument reference - http #5

Open qzio opened 9 years ago

qzio commented 9 years ago

I get this warning when I require 'consul/client'

I'm using ruby 2.2.0

app@workers:/tmp$ cat test.rb
require 'rubygems'
require 'consul/client'
puts "ok"
app@workers:/tmp$ ruby test.rb
/var/lib/gems/2.2.0/gems/consul-client-0.1.1/lib/consul/client.rb:34: warning: circular argument reference - http
ok
app@workers:/tmp$ ruby -v
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux-gnu]
app@workers:/tmp$ gem list -l|grep consul-client
consul-client (0.1.1)
app@workers:/tmp$

Is this warning something I need to worry about?

xaviershay commented 9 years ago

yeah should fix it, but also you probably don't want to use this library. See https://github.com/WeAreFarmGeek/diplomat

AvnerCohen commented 9 years ago

I suggest to add this recommendation in the README for future users. and maybe some deprecation /unmaintained notice.

xaviershay commented 8 years ago

Fixed in #44