search

xaya / libxayagame

MIT License
21 stars 20 forks source link

RPC stubs on github #37

Closed RyuMaster closed 5 years ago

RyuMaster commented 5 years ago

Can we keep RPC generated stubs on github? On Windows, there is no easy way to generate those, i.e. library I have under msys can be only build without rpc-stubs support. So I need to switch to Linux, build there, then copy-past back on every clean update.

domob1812 commented 5 years ago

I don't think we should. But I'm happy to upload them every time something changes to some server (could even be public for everyone).

RyuMaster commented 5 years ago

That would be nice.

RyuMaster commented 5 years ago

Also then, is it possible to add some flag, that would ignore stub generation? Right now, I have to manually delete it from makefile, every time I git pull and build for windows

domob1812 commented 5 years ago

The problem with premade stubs is that I don't know how correct they actually are - since they presumably depend in theory on your exact version of jsonrpccpp. Thus this is all a hacky solution - so I don't want to make it too official.

Why can you build jsonrpccpp fine but not the stub generator in the first place?

domob1812 commented 5 years ago

I believe that stub-generation on Windows works now, so we can close this.

domob1812 commented 5 years ago

Also note that if we generate a source release (make dist), then the stubs will be included in it. So this is/was mostly a problem for working from the repository directly.