search

xbapps / xbvr

Tool to organize and stream your VR porn library
348 stars 129 forks source link

Funscripts with optional metadata tags can block heatmap generation #1734

Closed Mellified closed 6 months ago

Mellified commented 6 months ago

The funscript metadata section can include a "Version" tag, which by convention is a floating point number. When xbvr tries to generate a heatmap for a funscript which includes "Version":1.0 it will fail with an error:

level=warning msg="json: cannot unmarshal number into Go struct field Script.version of type string"

This is a valid tag, and should be processed. But rather than fixing this specific problem the more general case should be solved. Any problems with optional tags should be ignored, rather than causing the heatmap generation process to fail.

Mellified commented 6 months ago

Note that SLR uses a version tag in its AI generated scripts at the top level of the JSON file. This tag does not block funscript generation in xbvr. It is only when the version tag is included in the Metadata section of the funscript JSON when the problem occurs.