xbapps / xbvr

Tool to organize and stream your VR porn library
345 stars 129 forks source link

Arm based Docker builds #252

Open Tweeticoats opened 4 years ago

Tweeticoats commented 4 years ago

I have an arm based nas (helios 4) and need a arm docker image. To get this to work I needed to make 2 changes: Line 8 you are downloading go with curl but the linux-amd64 arch. Could we add an ARCH variable as I need to download linux-armv6l when building the image.

The other problem I have is you are using distoless base image and there is no arm image. Changing this to a basic debian image allows me to build and run this inside a container. I can see the reason for using this but is there a similar project that supports arm as well as amd64?

cld9x commented 4 years ago

I have no experience with multi-arch Docker images, but think it’s a low hanging fruit

bounty1342 commented 4 years ago

Need to install : https://github.com/docker/buildx

docker buildx build \ --push \ --platform linux/arm/v7,linux/arm64/v8,linux/amd64 \ --tag xbapps xbvr:buildx-latest .

https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

kjboa commented 2 years ago

This would be a nice feature