search

xbenjii / torrentexpander

Automatically exported from code.google.com/p/torrentexpander
0 stars 0 forks source link

Make codes more readable #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The source code is difficolut to read.
There are too many inline codes and no comments.
It needs proper indenting.
Good work

Original issue reported on code.google.com by login...@gmail.com on 21 Nov 2011 at 5:41

GoogleCodeExporter commented 8 years ago 
Issue 8 has been merged into this issue.

Original comment by addicted...@gmail.com on 22 Nov 2011 at 10:45

GoogleCodeExporter commented 8 years ago 
I'm starting to get lost in my own code ; this is never a good sign.
I do agree with you

I have a few functionalities to add (fanarts, better support of rTorrent, 
remove torrent from transmission in destructive mode) and my next priority will 
be to clean the code and start documenting it.

Thanks

Original comment by addicted...@gmail.com on 22 Nov 2011 at 11:01

GoogleCodeExporter commented 8 years ago 
Very Good.

Original comment by login...@gmail.com on 23 Nov 2011 at 10:46

GoogleCodeExporter commented 8 years ago 
Done in latest SVN build
Let me know if this is commented enough

Original comment by addicted...@gmail.com on 27 Nov 2011 at 6:26

GoogleCodeExporter commented 8 years ago 
Yes, the comments are good, but it still remain too many inline code.

Original comment by login...@gmail.com on 28 Nov 2011 at 5:56

GoogleCodeExporter commented 8 years ago 
On line 1006 there is a strange character.

Original comment by login...@gmail.com on 28 Nov 2011 at 5:58

GoogleCodeExporter commented 8 years ago 
Also look line 77 and 136, but it's not important.

Original comment by login...@gmail.com on 28 Nov 2011 at 6:00

GoogleCodeExporter commented 8 years ago 
Okay
Got rid of those strange characters - On my Mac, they look like simple spaces.
I had to preview the script in google code in order to see them.

What do you mean by inline code ? You mean if / elif / fi / then / for /done, 
etc... on a single line ?
Thanks

Original comment by addicted...@gmail.com on 28 Nov 2011 at 7:55

GoogleCodeExporter commented 8 years ago 
yes, also more iterative code will be nice.

Original comment by login...@gmail.com on 29 Nov 2011 at 10:34

GoogleCodeExporter commented 8 years ago

Original comment by login...@gmail.com on 4 Jan 2012 at 11:21