Naming issue - inserting unnecessary space

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Any file that is series SxEE
2. Enable copy to specified path and file cleanup

What is the expected output? What do you see instead?
Expect Top.Gear.SxEE to be renamed Top Gear SxEE and copied to /destination/Top 
Gear/Season/Top Gear SxEE.xxx

Instead see renamed as Top Gear  SxEE and copied to /destination/Top Gear 
/Season/Top Gear  SxEE.xxx

Not a big deal breaker to those with new collections, but for us with existing 
ones it would quickly make for a messy XBMC database etc etc

What version of the product are you using? On what operating system?
Not sure on how to find this out. I have run -u on 7th Feb 2012 so it is up to 
date. Using Ubuntu 11.04.

Please provide any additional information below.

After wasting time playing around with sed to remove spaces, I solved the 
problem easily by deleting the unnecessary space between $series_title 
$series_episode$is_repack$quality$extension on line 1208.

Hope this helps, a minor issue on some fantastic work!

Original issue reported on code.google.com by lukegarr...@gmail.com on 7 Feb 2012 at 6:08

[GoogleCodeExporter]

Hi
I've been looking at processed files from torrentexpander and I don't 
experience this issue using the latest SVN.
Can you try it again with the latest SVN and let me know how it works for you ?
http://code.google.com/p/torrentexpander/source/browse/trunk/torrentexpander.sh

According to what I see in this SVN, the change you made in line 1208 should 
break the rest of the script (especially the part where the episode is moved to 
your series directory).

One of my friends may have experienced a similar issue with a specific series, 
but was unable to give me any details on filenames.

If this issue still happens with the SVN, I'll need to know when exactly the 
issue happens (during renaming or moving to TV series directory - you can know 
that by running the script manually), and what is the exact name of the torrent.

Thanks for your feedback and your kind words.

     Addictedtoscreens

Original comment by addicted...@gmail.com on 7 Feb 2012 at 7:25

[GoogleCodeExporter]

Oh, I think I got it, I didn't pay enough attention to your episode naming.

Chan you check your torrentexpander_settings.ini file and make sure this line 
hasn't been changed :
tv_shows_fix_numbering=yes

For torrentexpander to work correctly, It should be able to correct episode 
numbering and you should end up with this : SxxExx
Also, The episode should not be copied to /.../Top Gear/Season/ but instead 
/.../Top Gear/Season x/ or /.../Top Gear/Season xx/, depending on your settings.
If not, I'll need to know the exact naming of your episode, in order to correct 
it, for the rest of the script to work.

Thanks for your help improving torrentexpander.

        Addictedtoscreens

Original comment by addicted...@gmail.com on 7 Feb 2012 at 7:33

[GoogleCodeExporter]

File name is Top_Gear.18x02.HDTV_XviD-FoV.avi

Output of manually running torrentexpander:

Step 1 : Expanding / moving content of the torrent
Step 2 : Trying to solve TV Shows numbering issues
- Renaming Top_Gear.18x02.HDTV_XviD-FoV.avi to 
Top_Gear.1S08E02.HDTV_XviD-FoV.avi
Step 3 : Cleaning up filenames
- Renaming Top_Gear.1S08E02.HDTV_XviD-FoV.avi to Top Gear  S08E02.avi
Step 4 : Taking care of TV Shows, Music and Movie files
- Copying Top Gear  S08E02.avi to /media/TV/TV/Top Gear /Season 8/
That's All Folks

So you can see it inserts an unecessary space at the end of Top Gear. 
Additionally, it is also picking the wrong season (picking 8 instead of 18). 
Perhaps this is the issue.

Having a play around with other torrents, I agree it works fine. Just this 
naming system is putting it off.

Maybe it is the fact that it is SSxEE and your renaming system only parses SxEE 
from what I can see in the script? With S = ([123456789])?

Original comment by lukegarr...@gmail.com on 7 Feb 2012 at 8:43

[GoogleCodeExporter]

Fixed the issue. New code is attached.

Basically inserted a new parsing run for files named SSxEE - just modified and 
pasted your excellent work really.

Results:

1) for an SSxEE file -

Step 1 : Expanding / moving content of the torrent
Step 2 : Trying to solve TV Shows numbering issues
- Renaming Top_Gear.18x02.HDTV_XviD-FoV.avi to Top_Gear.S18E02.HDTV_XviD-FoV.avi
Step 3 : Cleaning up filenames
- Renaming Top_Gear.S18E02.HDTV_XviD-FoV.avi to Top Gear S18E02.avi
Step 4 : Taking care of TV Shows, Music and Movie files
- Copying Top Gear S18E02.avi to /media/TV/TV/Top Gear/Season 18/
That's All Folks

For an SxEE file:

Step 1 : Expanding / moving content of the torrent
Step 2 : Trying to solve TV Shows numbering issues
- Renaming Sherlock.1x01.A.Study.In.Pink.720p.HDTV.x264-FoV.mkv to 
Sherlock.S01E01.A.Study.In.Pink.720p.HDTV.x264-FoV.mkv
Step 3 : Cleaning up filenames
- Renaming Sherlock.S01E01.A.Study.In.Pink.720p.HDTV.x264-FoV.mkv to Sherlock 
S01E01.mkv
Step 4 : Taking care of TV Shows, Music and Movie files
- Copying Sherlock S01E01.mkv to /media/TV/TV/Sherlock/Season 1/
That's All Folks

All correct and functioning normally.

Hope this helps!

Original comment by lukegarr...@gmail.com on 7 Feb 2012 at 9:17

Attachments:

• torrentexpander.sh

[GoogleCodeExporter]

Hi

The changes you made are flawless.
I'll commit a new SVN tonight with your additional lines.
Thanks again.

      Addictedtoscreens

Original comment by archives...@gmail.com on 7 Feb 2012 at 12:14

[GoogleCodeExporter]

Hi
I've just included your fix to the latest SVN.
SSxEE episodes are now recognized correctly with this build. Thank you for the 
bug report and the fix.

      Addictedtoscreens

Original comment by addicted...@gmail.com on 7 Feb 2012 at 9:17

[GoogleCodeExporter]

I'll close this issue
Thanks again

Original comment by addicted...@gmail.com on 4 Mar 2012 at 6:36

• Changed state: Fixed