xbianonpi / xbian

XBMC on Raspberry Pi, Bleeding Edge
https://xbian.org
GNU General Public License v3.0
294 stars 44 forks source link

Gfx clutter during video playback #625

Closed NilsNojje closed 10 years ago

NilsNojje commented 10 years ago

On RC3 there is gfx clutter over and under the video during playback. If you toggle the playback menu, the region does not clear and traces of the menu remains on screen efter hiding it. Also subtitles does not render properly here and are suffering of the same issue.

CurlyMoo commented 10 years ago

Wondering if this isn't a XBMC bug instead of a XBian one?

rikardo1979 commented 10 years ago

other distro are OK so it's XBian

popcornmix commented 10 years ago

@NilsNojje Are you sure you haven't enabled non-default dirty rectanges? http://wiki.xbmc.org/index.php?title=HOW-TO:Modify_dirty_regions

For GL ES platforms algorithmdirtyregions should be set to 3. 1 and 2 will produce artefacts.

CurlyMoo commented 10 years ago

That could be the issue because by default XBian RC3 has the algorithmdirtyregions set to 1.

NilsNojje commented 10 years ago

Testing was done on a fresh install. Only changes was localization and turning on hdmi passthrough for audio decoding.

Will try setting to "3".

rikardo1979 commented 10 years ago

OK, have tried to change it from 1 to 3 and now I have no proper HDMI output, the picture is just flashing on remote presses or spontaneously so cant even see the GUI. Tried to reboot and its same

NilsNojje commented 10 years ago

Tried now changing to "3". Playback works with subtitles and playback menu, but the main GUI when just browsing menus and such, blanks out to black all the time. It pops up when you press a button, but goes back to black after a few milliseconds.

Edit: I started playback with the iPhone remote and that works well, but using the GUI is not possible.

My advancedsettings.xml --> http://pastebin.com/3cqabciJ

popcornmix commented 10 years ago

Were there any other non-default advancedsettings in the section?

CurlyMoo commented 10 years ago

https://github.com/xbianonpi/xbian-package-xbianhome/blob/master/build/content-tpl/home/xbian/.xbmc/userdata/advancedsettings.xml

rikardo1979 commented 10 years ago

I have also noticed that the CEC remote acting bad since the update. it has the multi press issues on single button press

popcornmix commented 10 years ago

I'd say remove:

<gui>
<nofliptimeout>1000</nofliptimeout>
<algorithmdirtyregions>1</algorithmdirtyregions>
</gui>

(nofliptimeout is zero by default).

<useddsfanart>false</useddsfanart>

is a default setting, so should be removed.

I'd suggest:

<cachemembuffersize>20971520</cachemembuffersize>

is removed too. If not present it defaults to 20M on a 512M Pi and 2M on a 256M Pi.

rikardo1979 commented 10 years ago

@popcornmix thanks m8 removed suggested lines and it seems to fixed the issues havent touched cachemembuffersize yet but rest seems to be working fine even the CEC remote working as it should

Nice catch ;)

CurlyMoo commented 10 years ago

@popcornmix, can you do a pull request on the advancedsettings.xml?

anaconda commented 10 years ago

As far as I know these were needed for the CuBox-i/HB. But we really should kill -xbianhome and ship an appropriate advancedsettings.xml in -xbmc packages (in system/).

NilsNojje commented 10 years ago

Applied all changes that @popcornmix suggested and I can confirm it's working fine again.

CurlyMoo commented 10 years ago

@anaconda: agree. We should also limit these pre-installed files to the ones we actually changed and let the rest be installed by xbmc.

CurlyMoo commented 10 years ago

I've updated the RC3 image with this fix. If @anaconda and @mk01 can then fix the packages.

nicolalorusso commented 10 years ago

@popcornmix: you win. I have just commented out the GUI section and all works fine. Thanks a lot.

anaconda commented 10 years ago

@CurlyMoo can you please test nofliptimeout -1 and algorithmdirtyregions 1 on a CuBox-i/HB?

See https://github.com/OpenELEC/OpenELEC.tv/commit/a4dac78e55ad32154f5c066dfa91a097cf0f21c6

CurlyMoo commented 10 years ago

Doesn't really matter, the conflicting RPi settings also work fine.