xbianonpi / xbian

XBMC on Raspberry Pi, Bleeding Edge
https://xbian.org
GNU General Public License v3.0
294 stars 46 forks source link

Cannot set remote nfs share as system backup destination #902

Closed tbertels closed 2 years ago

tbertels commented 2 years ago

When choosing a remote nfs share as system backup destination, after a few seconds a message is shown saying that the setting cannot be saved.

Log file: kodi-debug.log Check after 2021-10-05 16:26:17.774:

This doesn't work (gets reverted):

2021-10-05 16:26:59.122 T:14377   DEBUG <general>: systemSettingControl setValue
2021-10-05 16:26:59.123 T:14377   DEBUG <general>:  
2021-10-05 16:26:59.123 T:14377   DEBUG <general>: [False, 'File', 'nfs://192.168.1.5/volume1/3 Tera Backup/Backup/Raspberry-backups/Bureau/$(hostname)_xbian_image_$(date +%F).img', 'daily', '0']

But this does work (it's what the setting above gets reverted to:

2021-10-05 16:27:00.486 T:14405   DEBUG <general>: systemSettingControl setValue
2021-10-05 16:27:00.486 T:14405   DEBUG <general>:  
2021-10-05 16:27:00.486 T:14405   DEBUG <general>: [0, 'File', '/media/Clé 64 Go/$(hostname)_xbian_image_$(date +%F).img', 'daily', '0']

Could it be because of False instead of 0 (type error?)? Or do remote backup just don't work?

mkreisl commented 2 years ago

A space in the pathname is a very stupid idea.

Please try it without the space

mkreisl commented 2 years ago

I have nevertheless tried this once:

1) create nfs share with space in path: works 2) choose this share as backup target: works too 3) start backup: does not work. the blank is not processed correctly

Conclusion: Please do not use spaces in the path, only spaces in the filename are currently accepted

mkreisl commented 2 years ago

I took care of it again, after I noticed that also spaces in filenames don't work anymore. Unfortunately there was some broken-optimization

However, in the staging repository is now a new package xbian-package-config-shell, with which both in the path and in the filename spaces are processed correctly

Please install the package and report if it works for you now

Thanks

tbertels commented 2 years ago

It's working fine with the update, thanks! Indeed it was strange because '/media/Clé 64 Go/[...]' did work.