search

xbikuna / nettopologysuite

Automatically exported from code.google.com/p/nettopologysuite
0 stars 0 forks source link

Align NTS trunk with JTS trunk #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The current NTS trunk looks aligned with JTS rev. 741 
(https://code.google.com/p/nettopologysuite/source/detail?r=1051).

So I need to:
1. Add LineDissolver and EdgeGraph code: 
http://sourceforge.net/p/jts-topo-suite/code/737/
2. Update NTS code with latest changes: 
http://sourceforge.net/p/jts-topo-suite/code/892/log/?path=/trunk

Looks like I have some stuff to do for holidays :)

Original issue reported on code.google.com by diegogu...@gmail.com on 11 Dec 2013 at 2:05

GoogleCodeExporter commented 8 years ago 
From my experience, the best way to synchronize NTS and JTS is to
browse through the JTS revision history and apply the changes subsequently to 
NTS. While this may take longer, we are sure to have the tiny improvements as 
well.

You can safely omit any revision of the oracle reader/writer classes. We can 
port it later as a hole.

The latest revision I have handled is JTS' rev 741 with r1051. This excludes 
the work on oracle reader/writer and LineDissolver.

Original comment by felix.ob...@netcologne.de on 11 Dec 2013 at 2:24

GoogleCodeExporter commented 8 years ago 
Also EdgeGraph isn't imported, right?

Original comment by diegogu...@gmail.com on 11 Dec 2013 at 2:59

GoogleCodeExporter commented 8 years ago 
According to this revision http://sourceforge.net/p/jts-topo-suite/code/737/ 
LineDissolver used to be in one namespace. Must have been refactored later.

I strongly urge you to apply changes step by step

Original comment by felix.ob...@netcologne.de on 11 Dec 2013 at 3:06

GoogleCodeExporter commented 8 years ago 
And apply changes is similar chunks, stating which JTS revision it resembles.

Original comment by felix.ob...@netcologne.de on 11 Dec 2013 at 3:07

GoogleCodeExporter commented 8 years ago 
ok maybe I can open a new ticket for Linedissolver and EdgeGraoh and work on it 
lately

Original comment by diegogu...@gmail.com on 11 Dec 2013 at 3:16

GoogleCodeExporter commented 8 years ago 
If you need that functionality right now, just add it in the LineDissolver 
namespace. It is where I was forced to quit keeping the repositories in sync.

Original comment by felix.ob...@netcologne.de on 11 Dec 2013 at 3:23

GoogleCodeExporter commented 8 years ago 
JTS commits from r742 to r849 added with r1123: 
https://code.google.com/p/nettopologysuite/source/detail?r=1123

Original comment by diegogu...@gmail.com on 29 Dec 2013 at 2:08

GoogleCodeExporter commented 8 years ago 
JTS commit r850 added with r1125:  
https://code.google.com/p/nettopologysuite/source/detail?r=1125
IMPORTANT! With this commit I've added also Dissolve and EdgeGraph namespaces 
to solution, with tests and for

Original comment by diegogu...@gmail.com on 2 Jan 2014 at 10:04

GoogleCodeExporter commented 8 years ago 
JTS commit 852 added with r1132. Added KMLWriter and improved GMLReader.

Original comment by diegogu...@gmail.com on 4 Jan 2014 at 3:25

GoogleCodeExporter commented 8 years ago 
JTS commits from 853 to 884 added with r1134. 
Made some changes in KMLWriter.
Made some (I hope) minor changes in WKTWriter too: http://goo.gl/K9RXis (see 
CreateFormatter method).
Exposed a bug in WKTWriter when formatting larg numbers: see 
TestWriteLargeNumbers1 and TestWriteLargeNumbers3.

Original comment by diegogu...@gmail.com on 6 Jan 2014 at 10:40

GoogleCodeExporter commented 8 years ago 
NTS trunk aligned to JTS trunk with commit r1145

Original comment by diegogu...@gmail.com on 13 Jan 2014 at 4:11

GoogleCodeExporter commented 8 years ago 
all tests pass, looks ok to me :)

Original comment by diegogu...@gmail.com on 13 Jan 2014 at 4:12

GoogleCodeExporter commented 8 years ago 
all kudos to diegoguidi
Thanks a lot. Now let us not loose track (again).

Original comment by felix.ob...@netcologne.de on 14 Jan 2014 at 7:41

GoogleCodeExporter commented 8 years ago 
I've subscribed the RSS feed :)
http://sourceforge.net/p/jts-topo-suite/code/feed/

Original comment by diegogu...@gmail.com on 14 Jan 2014 at 3:28