search

xblax / flashforge_ad5m_klipper_mod

Unoffical mod for Flashforge Adventurer 5M (Pro) 3D printers to run Moonraker, custom Klipper, Mainsail & Fluidd
GNU General Public License v3.0
82 stars 4 forks source link

merge changes #161

Closed skylatian closed 3 weeks ago

KaruroChori commented 3 weeks ago

I am not sure if this should be implemented the way it has been.

The material selection on the slicer is separate and comes with its own overrides during slicing. The machine configuration where the start macro and end macro are called is supposed to be valid for all materials (except for overrides).

We can have material specific behaviour, but they should be separate macros not placed in the current START/END. Those new would be called by the custom filament start gcode and filament end gcode under material properties.

skylatian commented 3 weeks ago

My apologies - I meant to merge this into my own head and I got some branches crossed. Please disregard it. This is just for my own usage, I’m planning on refining it eventually essentially with the method you described.