search

xblax / flashforge_ad5m_klipper_mod

Unoffical mod for Flashforge Adventurer 5M (Pro) 3D printers to run Moonraker, custom Klipper, Mainsail & Fluidd
GNU General Public License v3.0
82 stars 4 forks source link

Need to rename M25 #82

Closed johncotten closed 1 month ago

johncotten commented 2 months ago

When using Orca and inserting a pause, it sends command M25. Printer does not want to resume and gives error: "Print is not paused, resume aborted".

I inserted this following code into macros and that behavior disappears.

[gcode_macro M25]
rename_existing: M25.1
gcode:
  PAUSE
xblax commented 2 months ago

Do we know that's the difference between the M25 and the PAUSE? M25 is "Pause SD print", the error "Print is not paused, resume aborted" I would maybe expect from M24 "Start/resume SD print". Anyway, probably both should be handled:

[gcode_macro m24]
rename_existing: M24.6245197
gcode:
  {% if printer.pause_resume.is_paused %}
  RESUME
  {% else %}
  M24.6245197
  {% endif %}

[gcode_macro m25]
rename_existing: M25.6245197
gcode:
  PAUSE

Found this example here https://github.com/jschuh/klipper-macros/blob/main/pause_resume_cancel.cfg

johncotten commented 2 months ago

That maybe the answer. The resume command and resume button do not send a M24 command. The PAUSE command is preferable anyway because it doesn't leave the nozzle in place to ooze onto the print, plus we are probably doing the pause for filament change anyways... So I would agree adding both commands would be ideal.

Verified those macros work.

xblax commented 1 month ago

I added these macros, will be in the next release.