search

xblax / flashforge_ad5m_klipper_mod

Unoffical mod for Flashforge Adventurer 5M (Pro) 3D printers to run Moonraker, custom Klipper, Mainsail & Fluidd
GNU General Public License v3.0
83 stars 4 forks source link

klipperscreen: stops working after change of font size or theme #90

Closed xblax closed 1 month ago

xblax commented 1 month ago

After changing these settings in the menu, KlipperScreen just shuts down. No error is shown in the log. After manual restart the settings are applied. I think that might actually be intended behavior, to restart the application for these settings.

We might need a wrapper script to automatically restart KlipperScreen if the process terminates.

I like the large font size setting, I guess no one else tried it yet. Maybe that would even make sense as default.

consp commented 1 month ago

Good point, I'll have a look. Thought I tested it but maybe that was with running it manually and forgetting about it.

consp commented 1 month ago

Large also looke better yes

consp commented 1 month ago

It's a bug.

Traceback (most recent call last):
  File "/root/printer_software/KlipperScreen/screen.py", line 13, in <module>
    import gi
ModuleNotFoundError: No module named 'gi'

Tries to start with common python3 not the venv, can be fixed in the script

fix/klipperscreen-restart Wrapper script just to be sure, sourcing the venv fixes the restart but there might be actual "restarts" with exit 0 somewhere in which cast it will also continue. other exit codes stop the script.

xblax commented 1 month ago

Added to master and cleaned-up the branch. Can be closed.